Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Tester Wanted] Feature: DPL: support for multiple inverters #1216

Open
wants to merge 35 commits into
base: development
Choose a base branch
from
Open

[Tester Wanted] Feature: DPL: support for multiple inverters #1216

wants to merge 35 commits into from
+2,114 −997

Commits on Oct 31, 2024

  1. revert changes to PowerLimiter regarding battery discharge limit 

    this temporary while the code implementing support for multiple
inverters is rebased.
    @schlimmchen
    schlimmchen committed Oct 31, 2024
    Configuration menu
    Copy the full SHA
    c113670 View commit details
    Browse the repository at this point in the history

  2. Feature: DPL: support for multiple inverters

    @schlimmchen
    schlimmchen committed Oct 31, 2024
    Configuration menu
    Copy the full SHA
    0e33343 View commit details
    Browse the repository at this point in the history

  3. make yarn linter happy: avoid sideeffect

    @schlimmchen
    schlimmchen committed Oct 31, 2024
    Configuration menu
    Copy the full SHA
    4c2fe72 View commit details
    Browse the repository at this point in the history

  4. fix inverter communication config hint

    @schlimmchen
    schlimmchen committed Oct 31, 2024
    Configuration menu
    Copy the full SHA
    d765383 View commit details
    Browse the repository at this point in the history

  5. watch inverter serial for dc voltage for invalid values

    @schlimmchen
    schlimmchen committed Oct 31, 2024
    Configuration menu
    Copy the full SHA
    6865ed1 View commit details
    Browse the repository at this point in the history

  6. remove console.log() uses in DPL admin view

    @schlimmchen
    schlimmchen committed Oct 31, 2024
    Configuration menu
    Copy the full SHA
    f94271d View commit details
    Browse the repository at this point in the history

  7. afterall, we do support any combinations of inverters from the start

    @schlimmchen
    schlimmchen committed Oct 31, 2024
    Configuration menu
    Copy the full SHA
    71050e9 View commit details
    Browse the repository at this point in the history

  8. webapp: hide the whole card if no battery-powered inverter configured

    @schlimmchen
    schlimmchen committed Oct 31, 2024
    Configuration menu
    Copy the full SHA
    b0c40f5 View commit details
    Browse the repository at this point in the history

  9. add input element for total inverter output limit

    @schlimmchen
    schlimmchen committed Oct 31, 2024
    Configuration menu
    Copy the full SHA
    960cfb2 View commit details
    Browse the repository at this point in the history

  10. DPL config: round floats and convert to double 

    this seems to be the only way to force ArduinoJson to serialize the
value in the way we expect, i.e., with only the amount of decimal digits
that the value can actually provide as precision.
    @schlimmchen
    schlimmchen committed Oct 31, 2024
    Configuration menu
    Copy the full SHA
    2e504d8 View commit details
    Browse the repository at this point in the history

  11. address new webapp source code issues

    @schlimmchen
    schlimmchen committed Oct 31, 2024
    Configuration menu
    Copy the full SHA
    34d53c2 View commit details
    Browse the repository at this point in the history

  12. properly round negative floats 

    even though the values rounded using this function should not be
negative, we shall not leave this here the way that it is, simply
because the code will probably be copy'n'pasted, and suddently negative
floating point numbers are rounded incorectly.
    @schlimmchen
    schlimmchen committed Oct 31, 2024
    Configuration menu
    Copy the full SHA
    d542b12 View commit details
    Browse the repository at this point in the history

  13. do not assume household consumption is positive 

    if power sources other than DPL-managed inverters are exporting power to
the grid, the household consumption can be negative and the DPL must be
prepared for this.
    @schlimmchen
    schlimmchen committed Oct 31, 2024
    Configuration menu
    Copy the full SHA
    24bb5e5 View commit details
    Browse the repository at this point in the history

  14. webapp: add min values for general settings

    @schlimmchen
    schlimmchen committed Oct 31, 2024
    Configuration menu
    Copy the full SHA
    5af5dce View commit details
    Browse the repository at this point in the history

  15. split PowerLimiterInverter class 

    as battery-powered and solar-powered inverters work fundamentally
different, we implement the "DPL interface" in different classes,
such that the idiosyncrasies of the different inverter types don't
make it hard to write readable code.
    @schlimmchen
    schlimmchen committed Oct 31, 2024
    Configuration menu
    Copy the full SHA
    ed3f8ef View commit details
    Browse the repository at this point in the history

  16. remove isSolarPowered() from PowerLimiter*Inverters

    @schlimmchen
    schlimmchen committed Oct 31, 2024
    Configuration menu
    Copy the full SHA
    d6da18e View commit details
    Browse the repository at this point in the history

  17. optimize power limiter inverter implementations

    @schlimmchen
    schlimmchen committed Oct 31, 2024
    Configuration menu
    Copy the full SHA
    b64cca1 View commit details
    Browse the repository at this point in the history

  18. prevent overflow if current limit or output less than lower power limit

    @schlimmchen
    schlimmchen committed Oct 31, 2024
    Configuration menu
    Copy the full SHA
    8a39aa8 View commit details
    Browse the repository at this point in the history

  19. battery-powered inverters: enforce limits 

    we should not be requesting more power than allowed and we should not be
requesting less power than the lower power limit. to be sure, we now
enforce these limits explicitly.
    @schlimmchen
    schlimmchen committed Oct 31, 2024
    Configuration menu
    Copy the full SHA
    f061bb7 View commit details
    Browse the repository at this point in the history

  20. re-implement battery discharge current limitation

    @schlimmchen
    schlimmchen committed Oct 31, 2024
    Configuration menu
    Copy the full SHA
    101b1bc View commit details
    Browse the repository at this point in the history

  21. unreachable inverters cannot be controlled 

    if an inverter is unreachable or it is not configured to receive
commands, the DPL cannot control it and as such it cannot be considered
when trying to match the household consumption.
    @schlimmchen
    schlimmchen committed Oct 31, 2024
    Configuration menu
    Copy the full SHA
    9dd5fb8 View commit details
    Browse the repository at this point in the history

  22. battery-powered inverter: use current limit for calculations

    @schlimmchen
    schlimmchen committed Oct 31, 2024
    Configuration menu
    Copy the full SHA
    8efb580 View commit details
    Browse the repository at this point in the history

  23. DPL inverter details on console: optimize output

    @schlimmchen
    schlimmchen committed Oct 31, 2024
    Configuration menu
    Copy the full SHA
    5cb923d View commit details
    Browse the repository at this point in the history

  24. webapp: format DPL admin view

    @schlimmchen
    schlimmchen committed Oct 31, 2024
    Configuration menu
    Copy the full SHA
    d67bc72 View commit details
    Browse the repository at this point in the history

  25. DTU restart: switch to restart helper

    @schlimmchen
    schlimmchen committed Oct 31, 2024
    Configuration menu
    Copy the full SHA
    25d9ca4 View commit details
    Browse the repository at this point in the history

  26. introduce and use isEligible()

    @schlimmchen
    schlimmchen committed Oct 31, 2024
    Configuration menu
    Copy the full SHA
    5a7c8fa View commit details
    Browse the repository at this point in the history

  27. condense inverter debug infos/details

    @schlimmchen
    schlimmchen committed Oct 31, 2024
    Configuration menu
    Copy the full SHA
    fbbe618 View commit details
    Browse the repository at this point in the history

  28. respect total inverter output limit

    @schlimmchen
    schlimmchen committed Oct 31, 2024
    Configuration menu
    Copy the full SHA
    f0fc508 View commit details
    Browse the repository at this point in the history

  29. inverter is disqualified until its current limit is known

    @schlimmchen
    schlimmchen committed Oct 31, 2024
    Configuration menu
    Copy the full SHA
    e25ebb2 View commit details
    Browse the repository at this point in the history

  30. webapp: add translations for updated DPL UI

    @schlimmchen
    schlimmchen committed Oct 31, 2024
    Configuration menu
    Copy the full SHA
    52a7105 View commit details
    Browse the repository at this point in the history

  31. webapp: start fresh when adding an inverter 

    avoid picking up settings from the previously added or edited inverter
when adding a new inverter by creating a new object instance.
    @schlimmchen
    schlimmchen committed Oct 31, 2024
    Configuration menu
    Copy the full SHA
    e211f59 View commit details
    Browse the repository at this point in the history

  32. move "TODO" to PR description

    @schlimmchen
    schlimmchen committed Oct 31, 2024
    Configuration menu
    Copy the full SHA
    b6840fc View commit details
    Browse the repository at this point in the history

  33. Feature: Support DPL overscaling on all inverters 

    this change allows to support overscaling for all inverters, as the configuration of
inputs (which one is part of a particular MPPT) is now provided from withing the
code. this information is used to implement overscaling for any of the inverters
(which are generally compatible with OpenDTU(-OnBattery)).
    @vaterlangen @schlimmchen
    vaterlangen authored and schlimmchen committed Oct 31, 2024
    Configuration menu
    Copy the full SHA
    021a3e3 View commit details
    Browse the repository at this point in the history

  34. add proper support for solar-powered inverters (#1343)

    @AndreasBoehm @schlimmchen
    AndreasBoehm authored and schlimmchen committed Oct 31, 2024
    Configuration menu
    Copy the full SHA
    83693be View commit details
    Browse the repository at this point in the history

  35. webapp: DPL admin view fixups 

    * avoid v-show, use v-if
* do not add space to top of first card
* fix table with managed inverters
    @schlimmchen
    schlimmchen committed Oct 31, 2024
    Configuration menu
    Copy the full SHA
    4766f79 View commit details
    Browse the repository at this point in the history