Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for W5500 ethernet module #1231

Merged
merged 8 commits into from
Sep 13, 2024

Conversation

Gumbagubanga
Copy link

Based on the pull-request tbnobody#2068 from the upstream project, I adopted the changes to work with the newly introduced SPIPortManager.

Credits to @marvincarstensen and @LennartF22 for the implementation of the ETHSPI/W5500 support.

@Gumbagubanga Gumbagubanga marked this pull request as draft September 5, 2024 20:03
@Gumbagubanga Gumbagubanga marked this pull request as ready for review September 5, 2024 20:04
@Tpaydt
Copy link

Tpaydt commented Sep 6, 2024

Nice, good job

ESP32S3+W5500+NRF ist working now.

One more question.
Which connection is prioritized when I start the DTU?
I have now deleted the wifi settings.

@Gumbagubanga
Copy link
Author

Nice, good job

ESP32S3+W5500+NRF ist working now.

One more question. Which connection is prioritized when I start the DTU? I have now deleted the wifi settings.

As before Ethernet >> Wifi.

@AndreasBoehm
Copy link
Member

AndreasBoehm commented Sep 11, 2024

I just ordered a PoE Hat for my fusion board. Looking forward to try this PR.

@schlimmchen
Copy link
Member

Oh nice, that means this will be taken care of, as I would need to make the time somehow, even though I have the hardware already... Thanks @AndreasBoehm.

@schlimmchen schlimmchen linked an issue Sep 11, 2024 that may be closed by this pull request
Copy link
Member

@AndreasBoehm AndreasBoehm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as expected! Nice!

src/NetworkSettings.cpp Outdated Show resolved Hide resolved
src/NetworkSettings.cpp Outdated Show resolved Hide resolved
src/NetworkSettings.cpp Outdated Show resolved Hide resolved
src/NetworkSettings.cpp Show resolved Hide resolved
lib/ETHSPI/src/ETHSPI.h Show resolved Hide resolved
@schlimmchen schlimmchen merged commit 89d9a40 into hoylabs:development Sep 13, 2024
8 checks passed
@schlimmchen
Copy link
Member

Thanks @Gumbagubanga ❤️

@Gumbagubanga Gumbagubanga deleted the feature/W5500 branch September 13, 2024 20:39
@schlimmchen
Copy link
Member

There are bittersweet news regarding this PR/feature: I am going to revert these changes in favor of the upstream implementation of the SpiManager and the upstream support for W5500 Ethernet to keep the diff between this project and the upstream to a minimum.

I am kind of sorry that we lose this unique selling point. I like to think that @Gumbagubanga's effort added to Thomas motivation to merge tbnobody#2306, which replaces this feature, because earlier Versions of the W5500 support in the upstream project were not merged for a long time.

Thanks again to @Gumbagubanga and @marvincarstensen, as this feature was highly appreciated!

@Gumbagubanga
Copy link
Author

There are bittersweet news regarding this PR/feature: I am going to revert these changes in favor of the upstream implementation of the SpiManager and the upstream support for W5500 Ethernet to keep the diff between this project and the upstream to a minimum.

I am kind of sorry that we lose this unique selling point. I like to think that @Gumbagubanga's effort added to Thomas motivation to merge tbnobody#2306, which replaces this feature, because earlier Versions of the W5500 support in the upstream project were not merged for a long time.

Thanks again to @Gumbagubanga and @marvincarstensen, as this feature was highly appreciated!

No hard feelings. It's just code and for the time being I can use an old version. :-)
Don't forget to discard/reject my PR for the documentation project as well.

@schlimmchen
Copy link
Member

No hard feelings. It's just code

And time!

Don't forget to discard/reject my PR for the documentation project as well.

Oh no, that is still relevant and valid. The upstream docs should cherry-pick it 😉 Thanks for thinking about that!

schlimmchen added a commit that referenced this pull request Sep 30, 2024
schlimmchen pushed a commit to hoylabs/OpenDTU-OnBattery-docs that referenced this pull request Oct 10, 2024
schlimmchen pushed a commit to hoylabs/OpenDTU-OnBattery-docs that referenced this pull request Oct 10, 2024
schlimmchen pushed a commit to hoylabs/OpenDTU-OnBattery-docs that referenced this pull request Oct 29, 2024
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new discussion or issue for related concerns.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 31, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Request] add LAN support for OpenDTU Fusion Board
4 participants