Add optional "load current" to live view, MQTT and HASS. #1367
Conversation
change "load output" to optional handling
|
Based on issue #947
I will check the current. But I have to find a 24VDc Load first. |
src/WebApi_ws_vedirect_live.cpp
Outdated
| if (mpptData.loadOutputState_LOAD.first > 0) { | ||
| device["LOAD"] = mpptData.loadOutputState_LOAD.second ? "ON" : "OFF"; | ||
| } |
There was a problem hiding this comment.
I think we should publish it like this only if IL is available. Otherwise, if IL is not available but LOAD ist available, we display mpttData.loadOutputState_LOAD.second with a new label VIRTLOAD and add the respective texts/translations, as we then can assume that the device has a virtual load output, rather than (what you call) a physical load output. What do you think?
There was a problem hiding this comment.
A good idea, but I assume it will not work on all devices.
I'm pretty sure I can also configure the virtual load output on any device with (physical) load output.
In that case IL is always available and I can not distinguish if I use virtual or physical load output.
I will check my assumption on my system today. Stay tuned.
There was a problem hiding this comment.
Yes, if you have both then you can't distinguish which is used.
But anyway ... I like the idea. I think we can ignore this little disadvantage.
We just talk about the display in the web-view and keep MQTT and HASS like it is?
There was a problem hiding this comment.
I think that it is very strange that those "smaller" models have both a physical and a virtual load output, but only a single property "LOAD". Therefore I would assume that the physical and virtual load output are always in sync. And therefore I don't think that it is even a problem that it says "load output" in the live view for models who have both a physical and a virtual load output. So yes, let's do this: Show "virtual load output state" if no IL but LOAD is available.
We just talk about the display in the web-view and keep MQTT and HASS like it is?
Yes.
There was a problem hiding this comment.
Therefore I would assume that the physical and virtual load output are always in sync
Yes, they are.
Ok, I simulated different charger models
LOAD = true, IL = true
LOAD = true, IL = false
LOAD = false, IL = false
Charge controller with physical "load output" will publish "load output state" and "load current"
Charge controller without physical "load output" but configured "virtual output" will publish just "load output state"
Charge controller without physical "load output" and not configured "virtual output" will not publish "load output state" and "load current"