Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PowerMeter Class + SDM PowerMeter support #140

Merged
merged 2 commits into from
Mar 22, 2023
Merged

PowerMeter Class + SDM PowerMeter support #140

merged 2 commits into from
Mar 22, 2023

Conversation

Adminius
Copy link

New PowerMeter Class

  • Supports MQTT
  • SDM72/630 and similar Power Meters via RS485 adaptor

@helgeerbe helgeerbe merged commit e696382 into hoylabs:development Mar 22, 2023
@helgeerbe
Copy link
Collaborator

Had to add 41da6d4 to get it working. Wondering why this was not in the PR.

@Adminius
Copy link
Author

sorry, that's because I've manuely merged my brunch to dev branch

@helgeerbe
Copy link
Collaborator

I found some additional issues. Hopefully I fixed it so far. My shelly power meter is now working. Can you test, the development branch for your power meter?

@Adminius
Copy link
Author

my biggest problem sofar: I can't switch between MQTT and SDM, ESP reboots, I think because of MQTT reinitialisation.
MQTT unsubscribe won't work. That causes that settings will not be saved

@Adminius
Copy link
Author

MQTT is working
SDM Power Meter is working
Settings saving is working

@helgeerbe
Copy link
Collaborator

Perfect. I will follow the KISS principle (Keep it simple and stupid), and implement a reboot after config changes. So you don't have to deal with unsubscribe from old MQTT topics, or changing communication speed on the serial interface.
Just store the new settings->reboot->make a clean init.

@Adminius
Copy link
Author

that would be the easiest and safest solution.
somewhere was the hint: change and save settings without reboot, thats why I didn't made it...

Ok, some topics are still open: pin setting (and switch to softserial to free up a HW UART for BMS), baudrate from settings, address from settings.. I see this tasks by myself

.. and completly new option: HTTP with JSON parser to support Tasmota/Hinchi IR without MQTT

@berni2288
Copy link

.. and completly new option: HTTP with JSON parser to support Tasmota/Hinchi IR without MQTT

#141

Copy link

github-actions bot commented Apr 7, 2024

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new discussion or issue for related concerns.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants