Inhibit solar passthrough while battery below stop threshold #354
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* shorten DPL log prefix * canUseDirectSolarPower() was printed two times * _batteryDischargeEnabled was printed two times * convert boolean values to human-readable strings * add units where possible * split messages into block "before calculating new limit" and "after calculating new limit", as the latter cannot rely on _inverter being available. * order messages such that variables whose value is derived from other variables are printed later than their dependencies. * merge output into blocks (one instance near "Printout some stats") * remove more redundant info (produced in functions outside loop()) * print target grid consumption
we only want to inhibit solar passthrough if the SoC is *below* the stop threshold, not if it is equal to the stop threshold. otherwise, when discharging, we would discharge until the battery reached the stop threshold, then we would also inhibit solar passthrough, until the battery is charged to the SoC stop threshold plus one percent.
|
Checking my initial state diagram this was the initial behavior of the DPL. This must be removed in various refactorings. Thanks for finding this. I haven't seen this in my log. Because, when you stop draining the battery, voltage climbs above stropThreshold. |
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new discussion or issue for related concerns. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR mangles two changes. The commits are separated. They do, however, build on one another.
Reasons for 2:
For those circumstances I propose this new piece of the DPL puzzle: Solar passthrough is inhibited while the battery is below the stop threshold.
A new method
isBelowStopThresholdin introduced. However, the code inisStopThresholdReachedandisStartThresholdReachedwas not copied another time. Instead, a new generic implementation is used by all three methods.