Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: JK BMS: export (more) data to live view and MQTT #549

Merged
merged 1 commit into from
Dec 15, 2023

Conversation

schlimmchen
Copy link
Member

  • add more values to web app live view. this should add all interesting values for the web app live view. those include important values and values that change frequently.

  • add more interesting JK BMS dummy messages: one has 0% SoC and an alarm (discharge undervoltage) set. the other has the undertemperature alarm set.

  • add alarms and warnings to live view

  • publish alarm and status bits through MQTT individually

  • publish cell voltages to MQTT broker

  • remove trailing spaces in BatteryStats class

Current Live View:
Screenshot from 2023-12-14 21-47-57

Updated Live View:
Screenshot from 2023-12-14 21-40-07

* add more values to web app live view. this should add all interesting
  values for the web app live view. those include important values and
  values that change frequently.

* add more interesting JK BMS dummy messages: one has 0% SoC and an
  alarm (discharge undervoltage) set. the other has the undertemperature
  alarm set.

* add alarms and warnings to live view

* publish alarm and status bits through MQTT individually

* publish cell voltages to MQTT broker

* remove trailing spaces in BatteryStats class
@helgeerbe
Copy link
Collaborator

I'll merge it, but I wouldn't be able to test it.

@helgeerbe helgeerbe merged commit 6e78c5b into hoylabs:development Dec 15, 2023
8 checks passed
@indie89
Copy link

indie89 commented Dec 16, 2023

Thanks alot for continuing the work on JK BMS integration :-)!
Display of additional values works fine with me!
I'd be very interested in the value of "Cell Voltage Difference" (as it is named in the jkbms bluetooth app). It is the difference between the highest and the lowest cell voltage. This indicates in one value the "status of balance" of the battery which in my opinion is much more important information than e.g. the average cell voltage (which is nothing more than the overall voltage divided by the number of cells). That would really help to have all important info at one point and will make it unnecessary to look into the app from time to time to double check the "status of balance". Thanks alot :-)!

@schlimmchen schlimmchen deleted the jkbms-data-export branch December 16, 2023 19:59
@schlimmchen
Copy link
Member Author

I'd be very interested in the value of "Cell Voltage Difference"

@indie89 That value is not communicated by the BMS, but it is already being calculated in OpenDTU-OnBattery. I had it in the live view, but decided that I had to trim the live view down a bit, and so I cut this (and min/max cell voltage as well as battery temperature) away.

much more important information than e.g. the average cell voltage

Meh, I disagree. This is very subjective, of course. I cannot remember what healthy values are for the overall battery voltage, but I know very well the range for each cell. That's why I left it in there, so I wouldn't be dividing the overall voltage by 16 every time 😉

Let me try something... If I can create a new block for all cell-related values, and if it flows nicely in the browser, then we might be able to use the space to the right more efficiently, even if one or two issues are active (while most of the time none are active), and show many more values.

@indie89
Copy link

indie89 commented Dec 16, 2023

wow, thanks for the quick reply!

Ah, I didn't know, that this value is not communicated (did not check the mqtt data).
Sure, it is highly subjective, which value is most important.
I for sure follow your way and your suggestion to maybe use the space in the right block. I'm glad for every step and already so thankful for all your work :-)!

An other idea/suggestion: would it be feasible to make the displayed values configurable? In the "Einstellungen" / "Settings" -> "Batterie" / "Battery" section?

@schlimmchen
Copy link
Member Author

wow, thanks for the quick reply!

You caught me idling, a rare state the last weeks 😁

Ah, I didn't know, that this value is not communicated (did not check the mqtt data).

Well, look again, it actually is in the MQTT data:

image

It is not included in the live view.

An other idea/suggestion: would it be feasible to make the displayed values configurable?

I had this in mind as well. However, it is a lot of boilerplate code to implement to provide a very simple feature. So I am hesitating to do this. However, I think it is valid to add a switch to select whether or not to display the battery temperature values, because those might be invalid since attaching the probes and putting them in a meaningful location is completely optional. What do you think should be user-configurable to see in the live view?

Copy link

github-actions bot commented Apr 4, 2024

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new discussion or issue for related concerns.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 4, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants