-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: JK BMS: export (more) data to live view and MQTT #549
Conversation
* add more values to web app live view. this should add all interesting values for the web app live view. those include important values and values that change frequently. * add more interesting JK BMS dummy messages: one has 0% SoC and an alarm (discharge undervoltage) set. the other has the undertemperature alarm set. * add alarms and warnings to live view * publish alarm and status bits through MQTT individually * publish cell voltages to MQTT broker * remove trailing spaces in BatteryStats class
I'll merge it, but I wouldn't be able to test it. |
Thanks alot for continuing the work on JK BMS integration :-)! |
@indie89 That value is not communicated by the BMS, but it is already being calculated in OpenDTU-OnBattery. I had it in the live view, but decided that I had to trim the live view down a bit, and so I cut this (and min/max cell voltage as well as battery temperature) away.
Meh, I disagree. This is very subjective, of course. I cannot remember what healthy values are for the overall battery voltage, but I know very well the range for each cell. That's why I left it in there, so I wouldn't be dividing the overall voltage by 16 every time 😉 Let me try something... If I can create a new block for all cell-related values, and if it flows nicely in the browser, then we might be able to use the space to the right more efficiently, even if one or two issues are active (while most of the time none are active), and show many more values. |
wow, thanks for the quick reply! Ah, I didn't know, that this value is not communicated (did not check the mqtt data). An other idea/suggestion: would it be feasible to make the displayed values configurable? In the "Einstellungen" / "Settings" -> "Batterie" / "Battery" section? |
You caught me idling, a rare state the last weeks 😁
Well, look again, it actually is in the MQTT data: It is not included in the live view.
I had this in mind as well. However, it is a lot of boilerplate code to implement to provide a very simple feature. So I am hesitating to do this. However, I think it is valid to add a switch to select whether or not to display the battery temperature values, because those might be invalid since attaching the probes and putting them in a meaningful location is completely optional. What do you think should be user-configurable to see in the live view? |
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new discussion or issue for related concerns. |
add more values to web app live view. this should add all interesting values for the web app live view. those include important values and values that change frequently.
add more interesting JK BMS dummy messages: one has 0% SoC and an alarm (discharge undervoltage) set. the other has the undertemperature alarm set.
add alarms and warnings to live view
publish alarm and status bits through MQTT individually
publish cell voltages to MQTT broker
remove trailing spaces in BatteryStats class
Current Live View:
Updated Live View: