Cleanup #257
Merged
Cleanup #257
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boegel
reviewed
May 9, 2018
| # (see http://stackoverflow.com/questions/4748344/whats-the-reverse-of-shlex-split for alternatives if needed) | ||
| return subprocess.list2cmdline([str(x)]) | ||
| """Add quotes so it can be passed to shell""" | ||
| return quote(str(x)) |
There was a problem hiding this comment.
Can you check whether this implies that we can remove the monkey patching we do in EasyBuild?
There was a problem hiding this comment.
yep, looks like this should fix this.
I was already wondering why nobody complained about this, seems like it's because you had a workaround :)
|
@boegel i'm going to merge this, we should not forget to push to pypi |
This was referenced May 14, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.