p39: disable empty logging tests #344
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@stdweird this is not urgent at all, but at some point in the future I would like your opinion on this. |
stdweird
reviewed
Nov 6, 2023
| @@ -532,8 +532,10 @@ def test_zzz_fancylogger_as_rootlogger_logging(self): | |||
| msg = 'this is my string' | |||
| logging.debug(msg) | |||
|
|
|||
| # fails on python 3.11 | |||
| self.assertEqual(stringfile.getvalue(), '', | |||
| if sys.version_info < (3,7): | |||
There was a problem hiding this comment.
implement the else block instead of just skipping it
|
@stdweird remark addresses |
stdweird
reviewed
Nov 7, 2023
|
@stdweird fixed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems that around python 3.7 log stream handling was changed. (can't find the actual change in the changelog)
I believe this is a good thing as now "logging with logging" no longer disappears when using fancylogger, which used to happen.
We used to test specifically for this behaviour. How big the behaviour change is, I can't say. So I don't know if we should rework fancylogger or just disable the test. As I would like to get rid of fancylogger I would propose to just disable the test, as this "new" behaviour might make migrating away from facylogger easier.
but those are just my 50 cents.