Each time a version of Pharo is released we need to update the baseli… #595
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ne if we want to be able to be able to load smalltalk CI in the new Pharo version. Here is a little improvement to not have to do that again.
|
Hi @jecisc could you resolve the conflict so we can merge this? |
|
Done |
fniephaus
reviewed
Oct 11, 2023
| baselines | ||
| pharoVersionsFrom: aVersion | ||
|
|
||
| ^ (aVersion to: SystemVersion current major) collect: [ :v | ('pharo' , v asString , '.x') asSymbol ] |
There was a problem hiding this comment.
Turns out this only works in Pharo:
a MessageNotUnderstood occurred (error 2010), a Set does not understand #'current'
There was a problem hiding this comment.
Works in Squeak 5.1 as well. Is that error from GS?
There was a problem hiding this comment.
Is there a way to know if we are on Pharo, Squeak or Gemstone that works in all smalltalks?
There was a problem hiding this comment.
Sure, but do we really need to complicate this even more? I forgot about the semantics, but maybe the spec could just target #'pharo' instead (or #'pharoCommon'?) and then we have specific overrides for Pharo < 5 (e.g. #'pharo4.x')?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ne if we want to be able to be able to load smalltalk CI in the new Pharo version.
Here is a little improvement to not have to do that again.