Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Aspect-preserving calculations are off in some cases #212

Closed
hpjansson opened this issue Aug 23, 2024 · 1 comment
Closed

Aspect-preserving calculations are off in some cases #212

hpjansson opened this issue Aug 23, 2024 · 1 comment

Comments

@hpjansson
Copy link
Owner

The aspect-preserving calculations seem to be off in some cases, observed with sixels in #211. With -s, the image should fill the constraining dimension completely and not leave any blank space. We should also check if there's bad interaction with potential sixel fringe rows.
@hpjansson hpjansson mentioned this issue Aug 31, 2024
Closed
@hpjansson
Copy link
Owner Author

I think I've got this sorted now. Attaching a test binary for Windows x64: chafa-test-gh212.zip

@hpjansson hpjansson mentioned this issue Sep 3, 2024
Closed
hpjansson added a commit that referenced this issue Sep 9, 2024
@hpjansson
math: Make sure image extends to an edge when scaling
7594fe5 
Also make sure dimensions don't fall short of request. We do this by
always rounding up before capping the size with MIN().

Fixes #212 (GitHub).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@hpjansson