Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Topic/thread framework #7

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Topic/thread framework #7

wants to merge 6 commits into from

Commits on Mar 23, 2019

  1. Add threads framework 

    Add a framework to support different types of threading models including
user space thread packages such as Qthreads and argobot:

https://github.com/pmodels/argobots

https://github.com/Qthreads/qthreads

The default threading model is pthreads.  Alternate thread models are
specificed at configure time using the --with-threads=X option.

The framework is static.  The theading model to use is selected at
Open MPI configure/build time.
    @npe9 @hppritcha
    npe9 authored and hppritcha committed Mar 23, 2019
    Configuration menu
    Copy the full SHA
    4e046c8 View commit details
    Browse the repository at this point in the history

  2. threads: improve pthreads comp configury 

    use the OPAL_CONFIG_POSIX_THREADS macro

Signed-off-by: Howard Pritchard <[email protected]>
    @hppritcha
    hppritcha committed Mar 23, 2019
    Configuration menu
    Copy the full SHA
    3ab2738 View commit details
    Browse the repository at this point in the history

  3. fix thread_usage.h

    @npe9 @hppritcha
    npe9 authored and hppritcha committed Mar 23, 2019
    Configuration menu
    Copy the full SHA
    f169672 View commit details
    Browse the repository at this point in the history

  4. mca/threads: fix Pthreads mutex implementation.

    @shintaro-iwasaki @hppritcha
    shintaro-iwasaki authored and hppritcha committed Mar 23, 2019
    Configuration menu
    Copy the full SHA
    3faa052 View commit details
    Browse the repository at this point in the history

  5. threads: remove workaround for mpi wrappers 

    remove workaround introduced into the wrappers Makefile.
This can be done due to the configury refactor.

rework the threads framework configury to move a good chunk
of setup to the top config directory to make sure thread
package specific compile/link args are defined early in
the configure process.

Signed-off-by: Howard Pritchard <[email protected]>
    @hppritcha
    hppritcha committed Mar 23, 2019
    Configuration menu
    Copy the full SHA
    6452cb9 View commit details
    Browse the repository at this point in the history

  6. mca/threads: implement Argobots threading layer 

    config: fix thread configury

- Add double quotations
- Change Argobot to Argobots
config: implement Argobots check

If the poll time is too long, MPI hangs.

This quick fix just sets it to 0, but it is not good for the
Pthreads version. Need to find a good way to abstract it.

Note that even 1 (= 1 millisecond) causes disastrous performance
degradation.
    @shintaro-iwasaki @hppritcha
    shintaro-iwasaki authored and hppritcha committed Mar 23, 2019
    Configuration menu
    Copy the full SHA
    5575d71 View commit details
    Browse the repository at this point in the history