Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add built-in types/objects complex, bytes, memoryview, capsule, slice and builtins to HPyContext. #376

Merged
merged 6 commits into from
Nov 10, 2022

Conversation

fangerer
Copy link
Contributor

@fangerer fangerer commented Nov 8, 2022

This adds a few more built-in types/objects to the context.
The h_Builtins is of particular interest because it allows to do many operations that are available in Python but HPy does not yet have dedicated API for.

Further, we now also use Autogen to generate the (smaller) HPyContext struct for the CPython ABI.

@fangerer fangerer assigned mattip and unassigned mattip Nov 8, 2022
@fangerer fangerer requested a review from mattip November 8, 2022 13:54
@@ -343,7 +343,7 @@ jobs:
- name: Set up Python
uses: actions/setup-python@v2
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
uses: actions/setup-python@v2
uses: actions/setup-python@v4

Copy link
Contributor

@mattip mattip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Is there somewhere that a version is bumped?

@@ -363,7 +363,7 @@ jobs:
- name: Set up Python
uses: actions/setup-python@v2
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
uses: actions/setup-python@v2
uses: actions/setup-python@v4

@fangerer
Copy link
Contributor Author

LGTM. Is there somewhere that a version is bumped?

Thanks for the review.
Sorry, I don't get your question. Do you mean if GitHub or Ubuntu documented that it upgraded to Python 3.11 ?
I quickly tried to find out more. According to https://packages.ubuntu.com/jammy/python/python3 or https://packages.ubuntu.com/jammy-updates/python/ the used Python version is still 3.10.7.
GitHub Action setup-python says that it will use the version from PATH if no version was explicitly specified (see https://github.com/actions/setup-python). But I think it is because we used python-version: '3.x' and according to https://github.com/actions/setup-python/blob/main/docs/advanced-usage.md, this will use the latest stable version. And since 3.11 is the latest stable one, this would make sense to me.

@mattip
Copy link
Contributor

mattip commented Nov 10, 2022

I was referring to updating the ABI tag since this changes the ctx struct, but that seems more appropiate as we approach a release.

@fangerer fangerer merged commit 41a5a0a into hpyproject:master Nov 10, 2022
@fangerer fangerer deleted the fa/builtins branch November 10, 2022 11:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants