-
-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add built-in types/objects complex, bytes, memoryview, capsule, slice and builtins to HPyContext. #376
Conversation
.github/workflows/ci.yml
Outdated
@@ -343,7 +343,7 @@ jobs: | |||
- name: Set up Python | |||
uses: actions/setup-python@v2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
uses: actions/setup-python@v2 | |
uses: actions/setup-python@v4 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Is there somewhere that a version is bumped?
.github/workflows/ci.yml
Outdated
@@ -363,7 +363,7 @@ jobs: | |||
- name: Set up Python | |||
uses: actions/setup-python@v2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
uses: actions/setup-python@v2 | |
uses: actions/setup-python@v4 |
Thanks for the review. |
I was referring to updating the ABI tag since this changes the ctx struct, but that seems more appropiate as we approach a release. |
This adds a few more built-in types/objects to the context.
The
h_Builtins
is of particular interest because it allows to do many operations that are available in Python but HPy does not yet have dedicated API for.Further, we now also use Autogen to generate the (smaller)
HPyContext
struct for the CPython ABI.