Fix GitHub actions: fix Ubuntu version for py27 compat and cpp-check #388
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest Ubuntu does not provide Python 2.7 and also cpp-check seems to have some issues with it (runs, but fails with some preprocessor configuration issues).
fangerer
approved these changes
Dec 6, 2022
|
On the one hand we could add support for older python versions with deadsnake. On the other, at what point do we drop 2.7 language compatibility? |
I am not sure I follow, we did not drop it, right? (For the tests, my understanding was that PyPy test driver needs that, otherwise HPy itself was never 2.7 compatible?) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The latest Ubuntu does not provide Python 2.7 and also cpp-check seems to have some issues with it (runs, but fails with some preprocessor configuration issues).
From actions/setup-python#543 it seems that we need to stick to older Ubuntu.
Note: EOL of Ubuntu 20.04 should be in 2025