-
-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make autogen work under Windows+MSVC #440
Conversation
433908e
to
b1e6bb6
Compare
b1e6bb6
to
172ed2e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your contribution. In general, looks good to me. Maybe just remove the unused variable and then I'm happy to merge (if tests are passing, ofc).
We don't care about Python 2.7 anymore, right? |
Autogen has to be invoked from the MSVC command line so that cl.exe is in path.
172ed2e
to
ace5fed
Compare
Hi @KubaO, please excuse my very late answer. We don't really care about Python 2.7 in the sense that we don't run or support HPy on Python 2.7. However, we are running tests on PyPy and some of the test files therefore also need to be Python 2.7 compatible. Anyway, @mattip already has a fix (see #444 ). |
Just to be clear: #444 fixes the CI startup failure for 2.7, but if you want to use
then the 2.7 CI job will still fail, since that is the command it runs. Running this PR locally, everything here seems fine. |
Close/reopen to trigger CI |
This helps when using hpy under MSVC.