Work In Progress: Du Toit's Pillow Port to HPy #1
Conversation
| } | ||
|
|
||
| PyObject *py_size = HPy_AsPyObject(ctx, h_size); | ||
| PyObject *py_kernel = HPy_AsPyObject(ctx, kernel); |
There was a problem hiding this comment.
Note that HPy_AsPyObject increments ref count before returning the underlying PyObject* to you, so you should Py_DECREF(py_kernel) when you're done with it (or leave it be and fix it by migrating it all to HPy).
src/_imaging.c
Outdated
| PyObject *color = HPy_AsPyObject(ctx, h_color); | ||
|
|
||
| x = PyLong_AsLong(PyTuple_GetItem(coords, 0)); | ||
| y = PyLong_AsLong(PyTuple_GetItem(coords, 1)); |
There was a problem hiding this comment.
If this shows often, I think we can reconsider the support for tuple deconstruction in HPyArg_Parse. Once this is proper HPy code, it will be even more bloated, because you'll have to HPy_Close all the items retrieved from the tuple.
| @@ -121,7 +122,7 @@ typedef struct { | |||
| ImagingAccess access; | |||
| } ImagingObject; | |||
There was a problem hiding this comment.
Is there a way to directly convert between structs like this and an HPy type, without having to go through a PyObject?
There was a problem hiding this comment.
HPy_AsStruct. I think the best knowledge source for now are the tests in the HPy repository. Maybe this is something we can improve in the docs..
My port of Pillow to HPy so far: currently I have ported most of the Image class, as well as the ImageMorph class.