-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate to HPy 0.9.0. #2
base: hpy-9.2.0
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, thanks for making the changes!
@@ -2322,19 +2345,25 @@ static HPy Imaging_getextrema_impl(HPyContext *ctx, HPy self) { | |||
if (status) { | |||
switch (im_self->image->type) { | |||
case IMAGING_TYPE_UINT8: | |||
return HPy_NULL;//HPy_BuildValue(ctx, "II", extrema.u[0], extrema.u[1]); | |||
// return HPy_BuildValue(ctx, "BB", extrema.u[0], extrema.u[1]); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this comment can go - there was an issue while benchmarking in which PyPy didn't like HPy_BuildValue, but it worked fine on CPython and GraalPy, so these HPy_BuildValue comments are just a legacy of then
im->image8)); | ||
HPyDef_GET(Imaging_getattr_unsafe_ptrs, "unsafe_ptrs") | ||
static HPy Imaging_getattr_unsafe_ptrs_get(HPyContext *ctx, HPy self, void *closure) { | ||
Imaging im = ImagingObject_AsStruct(ctx, self)->image; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I remember I had an issue here where casting image to Imaging worked, but using ImagingObject_AsStruct didn't compile. If this compiles, it's fine
I've rebased Du Toit's original branch onto branch
hpy-9.2.0
of this repo (not sure who created that branch initially).Then I've migrated to HPy 0.9.0 and this is the corresponding PR.
The tests are not passing but haven't been passing before (making them pass is a separate task).
This is the current test output on my box: