Prevent overwriting user-defined supported completion function #67
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To integrate with vim-lsp this plugin overwrites the default function for getting LSP capabilities to check for snippet capabilities. However when doing this, it first calls the default capabilities function before adding its own keys into the request. This caused any user-defined functions that overwrite the default to be ignored. Instead, this plugin should use whatever is set as the global capabilities function value (which falls back to the default) to ensure that any user-defined functions aren't ignored
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To integrate with vim-lsp this plugin overwrites the default function for getting LSP capabilities to check for snippet capabilities. However when doing this, it first calls the default capabilities function before adding its own keys into the request. This caused any user-defined functions that overwrite the default to be ignored. Instead, this plugin should use whatever is set as the global capabilities function value (which falls back to the default) to ensure that any user-defined functions aren't ignored