Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Text rendering: Line wrapping bugs with Thai language #10217

Closed
hrydgard opened this issue Dec 1, 2017 · 3 comments · Fixed by #10236
Closed

Text rendering: Line wrapping bugs with Thai language #10217

hrydgard opened this issue Dec 1, 2017 · 3 comments · Fixed by #10236
Milestone
v1.5.4

Comments

@hrydgard
Copy link
Owner

hrydgard commented Dec 1, 2017

Details in hrydgard/ppsspp-lang#629 , making an issue here too so it's harder to miss as it's not a translation issue but a text rendering issue.
@hrydgard hrydgard added this to the v1.6.0 milestone Dec 1, 2017
@hrydgard hrydgard mentioned this issue Dec 1, 2017
Closed
@hrydgard
Copy link
Owner Author

hrydgard commented Dec 1, 2017

The first part of the problem (inadvertent extra line break) appeared in #9773 somewhere. As for the second part, that one's a bit baffling - Android only.

@unknownbrackets
Copy link
Collaborator

Sounds like we're not breaking it up by line there properly?

-[Unknown]

@hrydgard
Copy link
Owner Author

hrydgard commented Dec 1, 2017 •
edited
Loading

On Windows we don't need to, we just tell it to render the whole thing, lines and all. But in this case it goes wrong somehow, it decides to linebreak earlier than needed?

On Android it seems to be different.

https://stackoverflow.com/questions/6756975/draw-multi-line-text-to-canvas

unknownbrackets added a commit to unknownbrackets/ppsspp that referenced this issue Dec 3, 2017
@unknownbrackets
UI: Wrap text properly with explicit newlines.
4ad7107 
Fixes the non-Android part of hrydgard#10217.
unknownbrackets added a commit to unknownbrackets/ppsspp that referenced this issue Dec 3, 2017
@unknownbrackets
Android: Render text with newlines properly.
04c61ea 
Fixes the Android part of hrydgard#10217.

Not sure if the line height calculation is ideal but it's visually fine.
@unknownbrackets unknownbrackets mentioned this issue Dec 3, 2017
Merged
@unknownbrackets unknownbrackets modified the milestones: v1.6.0, v1.5.4 Dec 3, 2017
orbea pushed a commit to orbea/ppsspp that referenced this issue Dec 11, 2017
@unknownbrackets
UI: Wrap text properly with explicit newlines.
fdbe235 
Fixes the non-Android part of hrydgard#10217.
orbea pushed a commit to orbea/ppsspp that referenced this issue Dec 11, 2017
@unknownbrackets
Android: Render text with newlines properly.
2368e31 
Fixes the Android part of hrydgard#10217.

Not sure if the line height calculation is ideal but it's visually fine.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v1.5.4
Development

Successfully merging a pull request may close this issue.

UI: Fix text wrapping issues unknownbrackets/ppsspp
2 participants
@hrydgard @unknownbrackets