[Android] Display size remaining the same as rendering resolution after switching program

[Leopard20]

If you switch away from the PPSSPP (e.g by pressing home or simply by locking and unlocking the device), after returning to the app you can see that the display size has been cropped to the size of the rendering resolution.
This screenshot is taken from Tekken 6 @ 3x rendering resolution. HW scaler is Auto Native (in this case 1080p).

[hrydgard]

Yeah, these bugs are driving me crazy. They don't happen on all devices either.

[Leopard20]

😅 Yeah! Just when you think everything is good for the new version, another bug pops up!

[1234Sameer]

[Android] I guess these are same kind of bug. This happens when I return to ppsspp after minimizing. The first one is easy to reproduce but the 2nd one happens sometime. In the first one the screen looks like a stretched one but the settings and credits tabs are moved to the top. In the second the settings and credits tabs are moved to the centre and screen shows half black at the right. In both cases buttons don't work properly. I think this is a recent bug as the latest stable version don't have this bug. In both cases no games are launched. And these bugs don't happen if I lock and unlock my device.

[unknownbrackets]

I think this is related to the onCreated behavior I described in the other bug regrading the display width and height being updated at the wrong times. Maybe these devices are always doing an onCreated at the would size and then an immediate update to the right size.

-[Unknown]

[Leopard20]

Also happens in PPSSPP menu (not necessarily a game) if you, for example, click on Support PPSSPP and press back in market. (similar to the first screen shot by 1234Sameer)
@1234Sameer To get the lock-and-unlock bug you have to launch a game first!

[1234Sameer]

Hear is a Screenshot of Soul Calibur and This is the minimize bug( if I press home and relaunch my game from recent ). Here the buttons are affected with the bug while the game runs fine without any bug. Locking and unlocking didn't affect my game in any way. I tested multiple times with different rendering resolution and display resolution but couldn't get any kind of bug with locking and unlocking my device.

[Leopard20]

@1234Sameer
Oh you're right!
@hrydgard
Turns out the lock-and-unlock bug only happens on Vulkan, not OpenGL. (at least for me)

[1234Sameer]

My device doesn't support VulKan , so I can't test on it.
@Leopard20
As you said the display is cropped to rendering resolution, Can you confirm this with other rendering resolutions like 1xPSP. I mean the display should look more small with 1xPSP, right?

[Leopard20]

Exactly. 1x is smaller. But like I said it only happens on Vulkan.

[1234Sameer]

@Leopard20
Sorry for asking you twice,
but can you test with some more settings like
both rendering resolution and HW scaler 1xPSP or
Rendering resolution Auto(1:1) with HW scaler native.

[Leopard20]

It's OK.
Obviously if Rendering reolution is equal to HW scaler then you won't see the cropping. (e.g using 3x for both)
Another interesting thing I found is that if HW scaler is smaller than Rendering resolution (e.g HW scaler 2x and Rendering res. 3x) then you won't see the bug either.
In summery, for HW scaler equal to or smaller than Rendering res. there's no cropping bug.

However, if I use Auto for both Rendering res and HW scaler (general settings) and use a different Rendering res such as 2x for a game (but keep the scaler as Auto), then again I get a cropping bug but it looks a bit different:

However, if I use, say, a 3x Rendering Res. and then apply an Auto HW scaler in-game, there's no issue.
It means that the HW scaler setting is global, i.e. it remains the same in all games and changing one's settings changes all others'. Which might be why this is happening.

@hrydgard
That should narrow it down further!
Also, please separate HW scaler for each game. You could apply the setting during the shader cache loading screen, I guess.

BTW, you probably have realized that the 1st and 3rd screenshots by 1234Sameer are "portrait" bugs, right? In other words, the app is using the portrait layout for the menu items and controls, but the phone orientation is still landscape.
So it's a separate issue (but probably related by the same wrong behavior, such as what @unknownbrackets suggested)

[1234Sameer]

@Leopard20
So the HW scaler is somehow causing the bug, but I don't think only making the HW scaler game specific would solve the bugs. It may be able to solve the 2nd bug reported by you which looks different but won't necessarily fix the first bug. So let's say we make the HW scaler game specific and put HW scaler native and rendering resolution 1xPSP, Then we will still get the bug as normal. Plus what about the Vulkan API only.
Yes, we need to test on other devices (Vulkan) to confirm whether or not this is a device specific bug.

[Leopard20]

I didn't say it fixes the bug, it's just annoying that you can't set it per game (makes no sense either). But it CAN be used as a workaround too by using the Auto scaler for each game.

[unknownbrackets]

Has this improved with latest fixes?

-[Unknown]

[Leopard20]

Nope. And there isn't anything in the commits that could possibly fix this!

[1234Sameer]

@Leopard20
The bugs I reported, should I open another issue on this as they are different from yours and they still exist on PPSSPP v1.6.2-17-g6db008fc0 ? or it is good here.

[Leopard20]

I'm not sure!
@hrydgard What do you say?

[ghost]

Any update?

[ghost]

Can still reproduce this sometimes :/

[ghost]

Can't reproduce this issue after #16794 maybe the culprit is the HW scaler?

[hrydgard]

Likely.