Remove the Android display resolution selector #16794
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I think its benefit is absolutely tiny if any, and causes a lot more problems than it's worth. Bye. Note that this isn't the rendering resolution selector, that will of course still be there, but it's the "hardware scaler" resolution.
ghost
mentioned this pull request
|
Question: Why when I set rendering resolution to X1 and then use skip buffer rendering the resolution still in native device resolution 🤔 |
|
When using skip buffer rendering, we should probably disable the rendering resolution selector since it does nothing, it just renders to the backbuffer which is at your device resolution. |
|
But in HW Scaler the skip rendering resolution can be change |
|
That's true. But that's also the only real use of this feature, and it's not worth the testing and maintenance work. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think its benefit is absolutely tiny if any, and causes a lot more problems than it's worth.
Note that this isn't the rendering resolution selector, that will of course still be there, but it's the "hardware scaler" resolution.
See #16792