Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bezier low-quality graphics glitch is caused by Vertex Range Culling. #11692

Closed
xebra opened this issue Dec 23, 2018 · 3 comments · Fixed by #13763
Closed

Bezier low-quality graphics glitch is caused by Vertex Range Culling. #11692

xebra opened this issue Dec 23, 2018 · 3 comments · Fixed by #13763
Labels
Spline/Bezier tesselation Issues related to the PSP's hardware tesselation support
Milestone
v1.11.0

Comments

@xebra
Copy link
Contributor

xebra commented Dec 23, 2018

From #11425 (comment)

Seems, this issue is caused by Vertex Range Culling #11393.
@unknownbrackets
Copy link
Collaborator

Hmm, we could skip the vertex range culling when doing a curve. Maybe even only with low/medium quality.

I have not done any tests to confirm if the PSP draws splines or beziers with points outside the 4096x4096 valid space. It's entirely possible it always clips curves and they are never culled...

-[Unknown]

@unknownbrackets unknownbrackets added the Needs hardware testing Testing on a real device needed to determine correct behavior. label Dec 24, 2018
@xebra
Copy link
Contributor Author

xebra commented Dec 24, 2018

I think we need to skip it only with low/medium quality curves.

@hrydgard hrydgard added this to the v1.11.0 milestone Nov 11, 2020
@hrydgard
Copy link
Owner

Seems unlikely that any game would rely on bezier/spline curves hitting range culling... We should indeed just turn it off.

@hrydgard hrydgard added Spline/Bezier tesselation Issues related to the PSP's hardware tesselation support and removed Needs hardware testing Testing on a real device needed to determine correct behavior. labels Nov 11, 2020
hrydgard added a commit that referenced this issue Dec 13, 2020
@hrydgard
Turn off vertex range culling in bezier/spline calls.
f3ebd65 
When we do lower res tess than the real PSP, we cant trust the game to not cause range culling to kick in.

Fixes #11692
@hrydgard hrydgard mentioned this issue Dec 13, 2020
Merged
konistehrad pushed a commit to konistehrad/ppsspp that referenced this issue Dec 17, 2020
@hrydgard @konistehrad
Turn off vertex range culling in bezier/spline calls.
ba79de0 
When we do lower res tess than the real PSP, we cant trust the game to not cause range culling to kick in.

Fixes hrydgard#11692
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Spline/Bezier tesselation Issues related to the PSP's hardware tesselation support
Projects
None yet
Milestone
v1.11.0
Development

Successfully merging a pull request may close this issue.

Turn off vertex range culling in bezier/spline calls. hrydgard/ppsspp
3 participants
@hrydgard @unknownbrackets @xebra