Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Black or noisy turning pages animation in Valkyria Chronicles II (ULUS10515_1.00) #13320

Closed
justafella opened this issue Aug 22, 2020 · 3 comments · Fixed by #13327 or #13330
Closed

Black or noisy turning pages animation in Valkyria Chronicles II (ULUS10515_1.00) #13320

justafella opened this issue Aug 22, 2020 · 3 comments · Fixed by #13327 or #13330
Milestone

Comments

@justafella
Copy link

What happens?

While going through the pages of the Yearbook (or anything with pages to turn) in Valkirya Chronicles II (ULUS10515_1.00) the turning pages animation becomes all black or noisy. Not something to keep me or people from playing but I thought I should report anyway.

What should happen?

Pages should look like they are.

What hardware, operating system, and PPSSPP version? On desktop, GPU matters for graphical issues.

  • Windows 10 64 bit;
  • Acer Aspire ES15;
  • Intel Celeron QuadCore N3450;
  • Intel HD Graphics 500 (driver ver. 27.20.100.8476);
  • ppsspp-v1.10.3-470-ge8779fdc8-windows-amd64

Additional Info

  • Tried all the backends but none displayed the turning pages correctly;
  • Tried different rendering resolutions;
  • Tried turning on/off other options like Mode (Non-buffered & Buffered), Simulate block transfer effects, Vsync, Hardware transform, Software skinning, Hardware tesselation, Anisotropic filtering.
  • I have recorded what happens and I have made a save state. If there is any way to make them available for you to take a closer look, just tell me.

P.S: I searched around to see if this issue had already been reported. I'm sorry if it turns out to be a duplicate.

@justafella justafella changed the title Black or noisy turning pages animation in Valkirya Chronicles II (ULUS10515_1.00) Black or noisy turning pages animation in Valkyria Chronicles II (ULUS10515_1.00) Aug 22, 2020
@unknownbrackets
Copy link
Collaborator

Thanks for the report.

-[Unknown]

@unknownbrackets unknownbrackets added this to the v1.11.0 milestone Aug 23, 2020
@justafella
Copy link
Author

Tested the latest build and the issue persists if going back and forth the same page. Also, the pages don't look noisy anymore, but all black.

@unknownbrackets
Copy link
Collaborator

Ah, okay, the rest of this is caused by depth texturing.

Basically, we end up with no framebuffer attached, but also the texture released by ReleaseTexture in AttachFramebufferValid or AttachFramebufferInvalid.

Attach framebuf and release tex: 04114000
Creating FBO for 04114000 (z: 04088000) : 256 x 256 x 0
Saved safe size (256x256) 04114000 to 04134000
Decimating FBO for 04114000 (256 x 256 x 0), age 6
Detach framebuf (tex now dead): 04114000

The reason? It xors the hash twice, making it all the way back to the original hash and preventing rebuild.

-[Unknown]

unknownbrackets added a commit to unknownbrackets/ppsspp that referenced this issue Aug 24, 2020
We could have multiple detaches, and we delete the texture on attach, so
we really must make sure we recreate.

Fixes hrydgard#13320.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants