Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VFPU: Compute sines and cosines in double precision. #13526

Merged
merged 1 commit into from
Oct 10, 2020

Conversation

hrydgard
Copy link
Owner

@hrydgard hrydgard commented Oct 10, 2020

Fixes most of #12900, and should keep #2921 working.

This was originally suggested as a solution for #2921 in #6329 , but I had forgotten about that. While sin/cos might be a little slower than sinf/cosf, I don't think it'll actually matter much in reality.

The proper solution is of course to reverse engineer the PSP VFPU's functions.

Come to think of it, what breaks #12900 might be the response to inf/nan values.. But difficult to easily test.

Anyway, for future work in this area, we have to make sure to thorougly test invalid inputs in addition to the exact cardinal directions and so on.

Let's see if we can do without the special checks in double precision.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant