Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add back the old implementation of vfpu_sin/cos/sincos. #13706

Merged
merged 2 commits into from
Nov 24, 2020

Conversation

hrydgard
Copy link
Owner

@hrydgard hrydgard commented Nov 23, 2020

I hate to do this, but here we go.

Reverts #13526 (#13705 (Cho Aniki Zero) and #13671 (Hajime no Ippo) broke), but keeps the new implementation too, specifically for Hitman Reborn Battle Arena 2, see #13605 (uses a compat.ini flag).

Temporary measure to avoid regressions in 1.11.

Hope to more accurately reverse engineer these operations in the future.

@hrydgard hrydgard added this to the v1.11.0 milestone Nov 23, 2020
@hrydgard hrydgard merged commit 51b213e into master Nov 24, 2020
@hrydgard hrydgard deleted the vfpu-sincos-double-compat branch November 24, 2020 08:08
@somepunkid
Copy link

Forgot to add this, but this temp fix also applies to ULJS00157 - Hitman Reborn Battle Arena (the first game). Same exact issues with both games, perhaps the same variable can be added to the compat for now for future builds.

@hrydgard
Copy link
Owner Author

hrydgard commented Dec 5, 2020

@somepunkid thanks, applied.

@unknownbrackets
Copy link
Collaborator

I had done some initial testing at some point and it seemed like the least significant 8 bits of the results were always zero, but maybe I'm mixing my memory with the square root.

Probably the best option is to model this with a lot of results and figure out what gives us the most matches.

-[Unknown]

@somepunkid
Copy link

I had done some initial testing at some point and it seemed like the least significant 8 bits of the results were always zero, but maybe I'm mixing my memory with the square root.

Probably the best option is to model this with a lot of results and figure out what gives us the most matches.

-[Unknown]

If this is attempted, or build testing is required, I can test variables in-game. Thanks to you both, as always :>

konistehrad pushed a commit to konistehrad/ppsspp that referenced this pull request Dec 17, 2020
@fp64 fp64 mentioned this pull request Feb 19, 2023
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants