Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auto Max Quality mipmap generation not always good for transparent textures #14986

Open
hrydgard opened this issue Oct 7, 2021 · 3 comments
Open
Labels
GE emulation Backend-independent GPU issues
Milestone

Comments

@hrydgard
Copy link
Owner

hrydgard commented Oct 7, 2021

Most 3D games benefit quite a bit from the new option, but there are cases where it has some odd effects.

Possibly, we should avoid generating mipmaps for textures that contain transparency to avoid this.

Anuskuss found this case in Pursuit Force, open in tabs and flip to see it:

https://media.discordapp.net/attachments/293316141479362560/895799905254273064/auto.png?width=1702&height=957
https://media.discordapp.net/attachments/293316141479362560/895799937688817694/max.png?width=1702&height=957

Where I guess the trees have some weird colors on their transparent parts, that bleed into the mipmaps.

@hrydgard hrydgard added the GE emulation Backend-independent GPU issues label Oct 7, 2021
@hrydgard hrydgard added this to the Future-Prio milestone Oct 7, 2021
@Anuskuss
Copy link
Contributor

Anuskuss commented Oct 8, 2021

Another example where Auto Max Quality is producing undesired effects:

@unknownbrackets
Copy link
Collaborator

I guess we could run our own blit that ignores zero-alpha pixels. But it'd mean keeping two separate textures - one for when alpha blending or testing is on, and one for when it isn't...

-[Unknown]

@Narugakuruga
Copy link
Contributor

Perhaps make it optional instead of disabling all transparent mipmap?
Maybe add a tool tip in the future "if auto max quality breaks game, you can tried the second option".
Because it did work well in many games

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
GE emulation Backend-independent GPU issues
Projects
None yet
Development

No branches or pull requests

4 participants