Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tales of phantasia and star ocean graphics issue vulkan on Exynos #12890

Closed
asbel123 opened this issue May 13, 2020 · 30 comments
Closed

Tales of phantasia and star ocean graphics issue vulkan on Exynos #12890

asbel123 opened this issue May 13, 2020 · 30 comments

Comments

@asbel123
Copy link

Look this issue on tales on phantasia i cant see background in battle on vulkan u need disable stencil test fix the issue samsung galaxy s9 and s8 exynos and i tried opengl no problem but really slow. There no issue on windows.
20200513_141659issue

I give u pictures
20200513_141643

@ghost
Copy link

ghost commented May 13, 2020

Tales of phantasia slow issue #8538 try ppsspp latest git build from here https://buildbot.orphis.net/ppsspp/

@hrydgard hrydgard added this to the v1.10.0 milestone May 13, 2020
@hrydgard hrydgard changed the title Tales of phantasia and star ocean graphics issue vulkan Tales of phantasia and star ocean graphics issue vulkan on Exynos May 13, 2020
@hrydgard
Copy link
Owner

hrydgard commented May 19, 2020

Getting somewhat different problems on Star Ocean (character not behind furniture, as if stencil wasn't on or zero) but yeah, it's not working right. Seems like another driver bug, sigh (or if we somehow end up not storing or loading stencil with DONT_CARE in a render pass...)

hrydgard added a commit that referenced this issue May 19, 2020
Appears to fix the Star Ocean issue and maybe more reported in #12890.

Strange though...
@hrydgard
Copy link
Owner

When that build is ready, please check if it fixes your problems.

hrydgard added a commit that referenced this issue May 19, 2020
Appears to fix the Star Ocean issue and maybe more reported in #12890.

Strange though...
@asbel123
Copy link
Author

I try the build already u fix star ocean first deapuatre vulkan perfect but tales of phantasia still the same now i can see arts display in battle menu display.
i try on weekend on my brother phone of snapdragon 855 see the difference for tales of phantasia cross edition

@ghost
Copy link

ghost commented May 20, 2020

I try the build already u fix star ocean first deapuatre vulkan perfect but tales of phantasia still the same now i can see arts display in battle menu display.
i try on weekend on my brother phone of snapdragon 855 see the difference for tales of phantasia cross edition

@asbel123 still slow on OpenGL?

@asbel123
Copy link
Author

Its fullspeed in opengl its will go slow on when cress village destroyed no problem on vulkan thats a difference plus battle swrils is faster on vulkan on samung galaxy s9

@ghost
Copy link

ghost commented May 21, 2020

Look this issue on tales on phantasia i cant see background in battle on vulkan u need disable stencil test fix the issue samsung galaxy s9 and s8 exynos and i tried opengl no problem but really slow. There no issue on windows.
20200513_141659issue

I give u pictures
20200513_141643

This is Tales of Phantasia Full Voice Edition (Jap) right?

@asbel123
Copy link
Author

Cross edition better version no more pause magic
Its fix the background new version on vulkan still cant see menu display text just battle menu text is fixed.
20200522_085112
Uploading 20200522_085116.jpg…

@unknownbrackets
Copy link
Collaborator

Did this used to work in v1.9.4? Or an older version? It'd help to figure out when it broke, if so.

-[Unknown]

@hrydgard
Copy link
Owner

hrydgard commented May 26, 2020

Could you create a frame dump, at any scene that's missing a background? Doesn't matter if the frame dump is created on PC or Android.

https://github.com/hrydgard/ppsspp/wiki/How-to-create-a-frame-dump

@asbel123
Copy link
Author

I find the build ppsspp has disable stencil test fix the graphics on vulkan send u pitcures.

1.6.3 548

@asbel123
Copy link
Author

Uploading 20200529_083921.jpg…

@asbel123 asbel123 reopened this May 28, 2020
@ghost
Copy link

ghost commented May 28, 2020

I find the build ppsspp has disable stencil test fix the graphics on vulkan send u pitcures.

1.6.3 548

@asbel123 the devs asking for a ge dump not for a picture 🤦

hrydgard added a commit that referenced this issue May 29, 2020
@hrydgard
Copy link
Owner

hrydgard commented May 29, 2020

So there's obviously some driver bug with regards to stencil testing here. I just got an idea for a possible workaround, but which will have a small performance penalty, just committed it.

If this works I'll try to reproduce the bug independently and report it to ARM for fixing...

@hrydgard
Copy link
Owner

@asbel123 Can you try again with the latest build from https://buildbot.orphis.net/ppsspp/ ?

@hrydgard
Copy link
Owner

hrydgard commented Jun 2, 2020

@asbel123 Could you please re-test as described in my last post above?

@hrydgard
Copy link
Owner

Gonna leave this hack in place and postpone further work to after 1.10.

@hrydgard hrydgard removed this from the v1.10.0 milestone Jun 14, 2020
@hrydgard hrydgard added this to the v1.11.0 milestone Jun 14, 2020
@hrydgard hrydgard modified the milestones: v1.11.0, v1.12.0 Dec 1, 2020
@ghost
Copy link

ghost commented May 2, 2021

I try the build already u fix star ocean first deapuatre vulkan perfect but tales of phantasia still the same now i can see arts display in battle menu display.
i try on weekend on my brother phone of snapdragon 855 see the difference for tales of phantasia cross edition

Any update and ge dump?

@unknownbrackets
Copy link
Collaborator

Maybe we should remove the pixel rounding if it's not actually helping. But maybe it is and that's why there haven't been further reports...

-[Unknown]

@ghost
Copy link

ghost commented Aug 28, 2021

@asbel123 any news?

@hrydgard hrydgard modified the milestones: v1.12.0, v1.13.0 Aug 28, 2021
@ghost
Copy link

ghost commented Oct 14, 2021

Found new issue look at the grass
1X resolution
Screenshot_2021-10-14-10-56-52-930_org ppsspp ppsspp
2X resolution
Screenshot_2021-10-14-10-57-01-386_org ppsspp ppsspp
software
Screenshot_2021-10-14-10-55-02-815_org ppsspp ppsspp
Tales of Phantasia - Narikiri Dungeon X.zip

@ghost
Copy link

ghost commented Oct 25, 2021

Tales Of Phantasia (ULJS0079)
No graphics glitch on my phone.
Screenshot_2021-10-25-21-43-20-782_org ppsspp ppsspp

@hrydgard
Copy link
Owner

@Gamemulatorer Is that one related to Auto Max Quality texture filtering?

@ghost
Copy link

ghost commented Oct 25, 2021

@Gamemulatorer Is that one related to Auto Max Quality texture filtering?

No

@ghost
Copy link

ghost commented Dec 29, 2021

Just noticed that this issue is cause by auto max quality.
Screenshot_2021-12-29-15-04-14-632_org ppsspp ppsspp
X1 PSP RESOLUTION

Increasing PSP RESOLUTION make the graphics issue disappear.
Screenshot_2021-12-29-15-04-39-355_org ppsspp ppsspp
10X PSP RESOLUTION

@unknownbrackets
Copy link
Collaborator

unknownbrackets commented Dec 31, 2021

FWIW, that's Narikiri Dungeon X, which is a remake of a GBC game, and the initial screenshots in this issue were for Tales of Phantasia X, a remake of a SNES game which is included with Narikiri Dungeon X. There's also Tales of Phantasia Full Voice Edition, which is a predecessor of sorts to Tales of Phantasia X. Ah, the many remakes of Tales...

Anyway, the grass issue is therefore definitely #14986. Doesn't seem related to the initial issue of missing background graphics in battles.

-[Unknown]

@leoxxx
Copy link
Contributor

leoxxx commented May 8, 2022

Is this issue for Cross Edition?
The title is ambiguous.

@ghost
Copy link

ghost commented Dec 13, 2022

This might be fix using the recently build? @asbel123?

@IrfanH495
Copy link

ULJS00079 - TALES OF PHANTASIA
Screenshot_20230616-023536_PPSSPP
Screenshot_20230616-024710_PPSSPP
Samsung m20
Exynos 7904
Mali-G71
Android 10
everything looks normal fine.
i don't have version Cross Edition.

@hrydgard
Copy link
Owner

I think this one was solved by the depth/stencil workaround (writing Z in the fragment shader even though we don't really want to change it) quite a while back. I'm closing.

@hrydgard hrydgard modified the milestones: Future-Prio, v1.14.0 Jun 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants