Libretro: add D3D11 support / fix GL context reset. #10809
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hrydgard
approved these changes
Mar 27, 2018
| @@ -1274,6 +1276,34 @@ void D3D11DrawContext::Clear(int mask, uint32_t colorval, float depthVal, int st | |||
| } | |||
| } | |||
|
|
|||
| void D3D11DrawContext::BeginFrame() { | |||
There was a problem hiding this comment.
I guess this is needed to restore state after RetroArch has done its drawing? I don't mind really, should be very cheap.
There was a problem hiding this comment.
yeah, I was a bit worried about the cost.
| @@ -70,6 +70,8 @@ ConsoleListener::ConsoleListener() : bHidden(true) | |||
| bUseColor = false; | |||
| #elif PPSSPP_PLATFORM(UWP) | |||
| bUseColor = false; | |||
| #elif defined(_MSC_VER) | |||
There was a problem hiding this comment.
This looked weird to me first but I see that it's just in the non-UI case.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
D3D11 support is still experimental but it does seem to work well enough. this includes a small change to thin3d_d3d11 by adding a BeginFrame implementation.
incidentally, I also found a fix for the GL context reset problem which was to simply request for the context to be cached during a reset. DeviceLost/Restore for GL and D3D11 are still unable to switch to a new context, but this is good enough for now I think.
fixes #10784