Adreno shutdown crash workaround #11786
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's a race during shutdown between the EmuThread writing commands, and the render thread which just lost the buffer.
unknownbrackets
approved these changes
Feb 10, 2019
|
What does Dolphin do - I thought, at least at some point, that they used mapped buffers? At least during shutdown, it seems like we should be able to unmap correctly. But not sure how to handle task switching indeed... -[Unknown] |
|
Yeah, we just need to figure that out somehow.. I think it can be rescued, but I don't have the time or energy to dig into it. Focusing on burning down the 1.8.0 milestone. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Turns out that if we keep a gl buffer mapped for writing, when the activity closes the buffer just disappears instantly (or, I haven't identified exactly where it disappears so we can wait the emuthread properly), causing a race with the emuthread.
Fixes #11739 , #11726 ,