Attempt support for Windows long paths #12550
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
At least, in most cases. If the filename is super long, it'll open twice, but we try to avoid.
Unlikely, though.
Fixes hrydgard#12503, but must be enabled.
|
Thanks, that's a lot of diff to review :) I'll look at it later. |
|
Admittedly skimmed some parts, but looking good! Let's merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some of the places I changed may not actually be affected by longPathAware, based on the documentation. That said, some things might just internally call affected APIs so I figured it's better to handle it everywhere.
-[Unknown]