Different handling of Download lifetimes. #13067
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…3057 (1.10 crash mysteries)
hrydgard
force-pushed
the
download-rework
branch
from
c200877
to
1a8084c
Compare
unknownbrackets
requested changes
Jun 28, 2020
| @@ -562,6 +565,7 @@ void Downloader::Update() { | |||
| for (size_t i = 0; i < downloads_.size(); i++) { | |||
| if (downloads_[i]->Progress() == 1.0f || downloads_[i]->Failed()) { | |||
| downloads_[i]->RunCallback(); | |||
| downloads_[i]->Join(); | |||
There was a problem hiding this comment.
We need to do this in CancelAll() too, or we'll crash now. For perf, I'd say a separate loop joining them after they are all marked canceled (though, not sure we will often have multiple downloads.)
-[Unknown]
There was a problem hiding this comment.
Good catch! I'll fix it up.
|
There, that should take care of it. We don't really do multiple downloads a lot, but good to be ready. |
unknownbrackets
approved these changes
Jun 28, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Might help an issue from #13057 (1.10 crash mysteries).
Very lightly tested but appears to work.