Ge: Restore saved context when ending a list #14034
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Explicitly trigger memchecks on readback.
Otherwise another list queued by a Head push could use the wrong context data. See hrydgard#13346.
|
Wow, very nice find! That's indeed a bit scary for a late merge, but maybe worth it! Before merging this, I'm gonna do quite a bit of testing of my library. Then, we'll let it bubble for a week, asking people on Discord to test stuff too - and I think we should hopefully be fine for a release next Sunday, or if it doesn't feel right, the weekend after... |
|
No problems as far as I can tell. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think this is the cause of #13346, based on logging for when the save/restore happens.
Basically, if you enqueue with a context address, that's where to save context before starting your list, and restore context after your list completes. It means that you don't intend any state modifications by your list to be permanent. But we were running other lists before eventually restoring after the interrupt processing finished.
This seems slightly risky for v1.11.0 and could use more testing on more games...
-[Unknown]