Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bezier/Spline: Fix logical error #14805

Merged
merged 1 commit into from
Sep 7, 2021
Merged

Bezier/Spline: Fix logical error #14805

merged 1 commit into from
Sep 7, 2021

Conversation

hrydgard
Copy link
Owner

@hrydgard hrydgard commented Sep 7, 2021

Must flush buffered data before we modify submitType. Otherwise it'll compute a bogus vertex shader ID during that flush.

Should fix #14774.

Really I want to refactor away gstate_c and pass around state objects, but ...

@hrydgard hrydgard added GE emulation Backend-independent GPU issues Spline/Bezier tesselation Issues related to the PSP's hardware tesselation support labels Sep 7, 2021
@hrydgard hrydgard added this to the v1.12.0 milestone Sep 7, 2021
@hrydgard hrydgard merged commit f239d79 into master Sep 7, 2021
@hrydgard hrydgard deleted the spline-flush-fix branch September 7, 2021 22:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
GE emulation Backend-independent GPU issues Spline/Bezier tesselation Issues related to the PSP's hardware tesselation support
Projects
None yet
Development

Successfully merging this pull request may close these issues.

(Android)(Vulkan) Texture Shader crash in SNK NEO games
2 participants