Vertex shaders: On platforms with uniform buffers, use indexing and loop over the lights. #16787
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hrydgard
force-pushed
the
lighting-loop
branch
from
11b8d0e
to
c2eee3a
Compare
…oop for real over the lights. Strangely, greatly speeds up pipeline creation on PowerVR.
hrydgard
force-pushed
the
lighting-loop
branch
from
c2eee3a
to
3b46409
Compare
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of duplicating the code for each light.
Strangely, maybe because there's less code to parse, this speeds up ubershader pipeline creation on PowerVR by over 30%. There shouldn't be any performance difference at runtime as the loop is trivial and easy for the driver to unroll if it feels like it.
For now, we only do this in Vulkan and D3D11, but it would be possible to also support in OpenGL, though the uniform management gets tricker (or we need to start using uniform buffers in OpenGL).