Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vulkan: Remove the remains of the input attachment experiment #17575

Merged
merged 1 commit into from
Jun 13, 2023

Conversation

hrydgard
Copy link
Owner

@hrydgard hrydgard commented Jun 13, 2023

Haven't been using these for a while.

Added these in #15944. I've since come to the conclusion here that I think it's better to try to deal with the issues using safe workarounds like copies, instead of relying on features with somewhat iffy driver support that are not universal across APIs anyway.

Haven't been using these for a while.

I've come to the conclusion here that I think it's better to try to
deal with the issues using safe workarounds like copies, instead of
relying on features with somewhat iffy driver support that are not
universal across APIs anyway.
@hrydgard hrydgard added the Code Cleanup Cleanup to make future work easier. Needs to be done sometimes. label Jun 13, 2023
@hrydgard hrydgard added this to the v1.16.0 milestone Jun 13, 2023
@hrydgard hrydgard merged commit 8eb55a6 into master Jun 13, 2023
@hrydgard hrydgard deleted the vk-rip-out-input-attachments branch June 13, 2023 20:33
hrydgard added a commit that referenced this pull request Jul 30, 2023
Accidentally disabled this in #17575

Helps #17797 but only on OpenGL on mobile. There's more to improve
there.

caps_.framebufferFetchSupported is now always set to false in Vulkan.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Code Cleanup Cleanup to make future work easier. Needs to be done sometimes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant