Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to the latest version of rcheevos. #17806

Merged
merged 1 commit into from
Jul 30, 2023
Merged

Update to the latest version of rcheevos. #17806

merged 1 commit into from
Jul 30, 2023

Conversation

hrydgard
Copy link
Owner

Good to keep up.

@hrydgard hrydgard added the RetroAchievements RetroAchievements related work label Jul 30, 2023
@hrydgard hrydgard added this to the v1.16.0 milestone Jul 30, 2023
@hrydgard hrydgard merged commit 36951a0 into master Jul 30, 2023
19 checks passed
@hrydgard hrydgard deleted the update-rcheevos branch July 30, 2023 10:19
@unknownbrackets
Copy link
Collaborator

Having seen some screenshots of these piling up, we should probably early-expire certain types of messages if more come in, or something...

-[Unknown]

@hrydgard
Copy link
Owner Author

hrydgard commented Jul 30, 2023

Yes, though this specific message type is specified to only appear once. It's mainly the leaderboard ones that are spammy. I will redesign the message display and put in some limits.

hrydgard added a commit that referenced this pull request Aug 8, 2023
PR #17806 upgraded rcheevos, after which a regression is reported in
issue #17631.

Experimentally revert to confirm.
hrydgard added a commit that referenced this pull request Aug 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
RetroAchievements RetroAchievements related work
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants