Remove the vertex cache option #18339
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hrydgard
added
GE emulation
hrydgard
force-pushed
the
delete-vertex-cache
branch
from
e635a26
to
a212985
Compare
unknownbrackets
approved these changes
Oct 11, 2023
There was a problem hiding this comment.
Seems reasonable to me. I didn't try again on RISC-V but archanox reported it didn't help all that much there anymore either, which doesn't surprise me.
At least on the device I have, most problems are what you'd expect: anything that you'd say "oh, I should vectorize this with SIMD" or "oh this might be using a lot of memory bandwidth" -> those things will be slow. Verts fit that bill for sure, but hashing them is probably not cheap either.
-[Unknown]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After the latest round of optimizations, which is now coming to a close, I can no longer measure a meaningful frame rate improvement ( > 1%) by using the vertex cache. I had hoped to reach this point, and I'm happy I did.
Since ~all it now does is to complicate the code, let's finally get rid of it.
Although, @unknownbrackets , might want to check if it still has a benefit on RISC-V, which doesn't do very well at vertex decoding?