libretro: context cleanup #19203
Merged
libretro: context cleanup #19203
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks OK to me, assuming you have tested it thoroughly, which it seems you have! |
hrydgard
approved these changes
May 28, 2024
5 tasks
|
It's better. RA will crash if I press F to go to window mode too quickly after launching a PSP game. If I wait a little longer then it doesn't crash RA. Or if I go in and out of fullscreen too quickly back to back it will crash. So doesn't seem completely stable. Using Chains of Olympus as an example. If I wait for the game to get past the ReadyatDawn screen then press F it doesn't seem to crash. If I do it sooner than that it tends to crash. Or like I said just going back and forth quickly. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A few changes in order to be able to toggle fullscreen with all available video drivers, at least on my Windows setup, so please test with other platforms. Also tried multiple core launches and closes on the same run, and all seems very solid here.
Please let me know if this
gpu->DeviceLost();method is not the best possible, but at least it works.Closes #10784