Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: split module 'main' into separate modules #8

Closed
a-vester opened this issue Sep 7, 2022 · 0 comments · Fixed by #10
Closed

refactor: split module 'main' into separate modules #8

a-vester opened this issue Sep 7, 2022 · 0 comments · Fixed by #10
Labels
refactor Refactoring code without introducing new features.

Comments

@a-vester
Copy link
Member

a-vester commented Sep 7, 2022

The main module contains all functions and has already 1400+ lines of code. Split it up into different modules to increase readability and maintainability.

  • clean
    • get_pure_ratings
  • consolidate
    • get_best_ratings
    • get_second_best_ratings
    • get_worst_ratings
  • translate
    • get_scores_from_ratings
    • get_scores_from_warf
    • get_ratings_from_scores
    • get_ratings_from_warf
    • get_warf_from_scores
    • get_warf_from_ratings
  • aggregate
    • get_weighted_average
  • warf
    • get_warf_buffer
@a-vester a-vester added the refactor Refactoring code without introducing new features. label Sep 7, 2022
a-vester added a commit that referenced this issue Sep 9, 2022
@a-vester
refactor: Split module 'main' into separate modules
0126c1a 
Closes #8
@a-vester a-vester mentioned this issue Sep 9, 2022
Merged
deepakparashar1987 pushed a commit that referenced this issue Sep 22, 2022
@a-vester
refactor: Split module 'main' into separate modules (#10)
7c11c1f 
Closes #8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
refactor Refactoring code without introducing new features.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor: Split module 'main' into separate modules hsbc/pyratings
1 participant
@a-vester