Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using PER_JOB_HISTORY_DIR for APEL reporting (HTCONDOR-293) #443

Merged
merged 2 commits into from
Mar 29, 2021

Conversation

markcoatsworth
Copy link
Contributor

New clean pull request for these changes, including fixes from previous comments

Copy link
Collaborator

@brianhlin brianhlin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like this commit accidentally stomps on changes related to #426. Also a few other suggestions.

contrib/apelscripts/condor_batch_blah.sh Outdated Show resolved Hide resolved
contrib/apelscripts/condor_batch_blah.sh Show resolved Hide resolved
contrib/apelscripts/condor_batch_blah.sh Outdated Show resolved Hide resolved
contrib/apelscripts/condor_batch_blah.sh Outdated Show resolved Hide resolved
contrib/apelscripts/condor_batch_blah.sh Outdated Show resolved Hide resolved
contrib/apelscripts/condor_batch_blah.sh Outdated Show resolved Hide resolved
contrib/apelscripts/condor_batch_blah.sh Outdated Show resolved Hide resolved
contrib/apelscripts/condor_batch_blah.sh Outdated Show resolved Hide resolved
contrib/apelscripts/condor_batch_blah.sh Outdated Show resolved Hide resolved
contrib/apelscripts/condor_batch_blah.sh Outdated Show resolved Hide resolved
@markcoatsworth
Copy link
Contributor Author

@brianhlin I just pushed an update which addresses all your previous comments. I also changed the Is-History-File-Valid check to look for a GlobalJobId instead of ClusterId since we're now using the former as the unique job identifier.

Copy link
Collaborator

@brianhlin brianhlin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Overriding unrelated osg-test failures

@brianhlin brianhlin merged commit e8b7567 into htcondor:V5-branch Mar 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants