Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Nested dictionaries hidden in Settings #169

Closed
JoshKarpel opened this issue Jul 24, 2019 · 0 comments · Fixed by #171
Closed

Nested dictionaries hidden in Settings #169

JoshKarpel opened this issue Jul 24, 2019 · 0 comments · Fixed by #171
Labels
bug Something isn't working

Comments

@JoshKarpel
Copy link
Contributor

JoshKarpel commented Jul 24, 2019 •
edited
Loading

When a top-level setting is a dictionary, if you set something under that key and then do a lookup for the dictionary itself, you get just the updated key.

Basically, my implementation hides the under-layers, because you get the key from the first map in the chain that has it.

Quick fix: do lookups out of the merged map.

Long-term fix: support one layer of nesting very well, normalize key case. #170
@JoshKarpel JoshKarpel added the bug Something isn't working label Jul 24, 2019
JoshKarpel added a commit that referenced this issue Jul 24, 2019
@JoshKarpel
resolve #169
8f74de2
@JoshKarpel JoshKarpel mentioned this issue Jul 25, 2019
Merged
JoshKarpel added a commit that referenced this issue Jul 25, 2019
@JoshKarpel
Fixups for bad requirements merging and hidden nested settings (#172)
961f48d 
* resolve #168 

* resolve #169
JoshKarpel added a commit that referenced this issue Jul 26, 2019
@JoshKarpel
version history for #168 and #169
39cdc81
@JoshKarpel JoshKarpel mentioned this issue Jul 26, 2019
Merged
JoshKarpel added a commit that referenced this issue Jul 29, 2019
@JoshKarpel
v0.4.2 (#171)
66f95c0 
* resolve #168 
* resolve #169
* resolve #165
* resolve #173
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

v0.4.2 htcondor/htmap
1 participant
@JoshKarpel