-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
shouldRecycle=false breaks UI when scrolling the elements fast. Issue#296 #299
Conversation
…#296 shouldRecycle=false breaks UI when scrolling the elements fast. Issue#296
@pzuraq I'm not familiar with the internals. Does this work? |
it's been a long time, I'd have to reboot a lot of context and unfortunately I'm stretched a bit too thin to do that at the moment 😕 I'll try to get back to this when I have time |
I don't know enough about VC to review this unfortunately. |
@pzuraq Can you please check this once. |
Should render the appendComponentPool only if ‘shouldRecycle’ is false We can stop using this fork when the following Issue/PR is resolved: html-next#296 html-next#299
Should render the appendComponentPool only if ‘shouldRecycle’ is false We can stop using this fork when the following Issue/PR is resolved: html-next#296 html-next#299
Also see this, get |
Anyone interested in helping maintain this repo? I don't know enough about the internals myself |
@rwwagner90 @pzuraq @runspired Can you guys give this another try ? this error is still happening |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall this change seems good.
I suspect there's a more efficient way to do this in keeping with the original rendering model, as in the original rendering model what this PR brings is exactly how the order of operations would have occurred, but we likely have deviated from that with time.
In |
Commit for the below issue.
Issue#296
Reference: #296