Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix to use 'abort' event instead of 'aborted' property #1458

Closed
wants to merge 3 commits into from

Conversation

briannielson
Copy link

Fixes #1455

@briannielson
Copy link
Author

Closing due to failing test.

@briannielson
Copy link
Author

Tests fail, but they need to be reworked to use a ClientRequest object as specified in web-incoming.js:

  /**
   * Does the actual proxying. If `forward` is enabled fires up
   * a ForwardStream, same happens for ProxyStream. The request
   * just dies otherwise.
   *
   * @param {ClientRequest} Req Request object
   * @param {IncomingMessage} Res Response object
   * @param {Object} Options Config object passed to the proxy
   *
   * @api private
   */

@briannielson briannielson reopened this Jun 16, 2020
@jayeshmend
Copy link

@briannielson any idea when this will be fixed as its creating issues at random interval.

@briannielson
Copy link
Author

briannielson commented Jun 1, 2021

@briannielson any idea when this will be fixed as its creating issues at random interval.

Sorry, I haven't been watching this PR or the related issue. We ended up patching the library in our codebase with this change. This caused tests to fail in this repo, but I didn't have time to spend on fixing the tests. This did appear to fix the issue in our production environment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error emitted on proxy server after original request is aborted
2 participants