Fix bug: x-forwarded-proto set incorrectly as httphttps or wswss #266
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When routed via multiple proxies, x_forwarded_proto set as httphttps or wswss instead of http,https or ws,wss, since + operator seems to have a higher precedence than the terniary operator and the expression was getting evaluated to true always
jfhbrook
added a commit
that referenced
this pull request
Jun 19, 2012
Fix bug: x-forwarded-proto set incorrectly as httphttps or wswss
|
Do you plan to publish this fix with a new npm package anytime soon? |
|
Good question. @cronopio Do you feel comfortable coordinating a release of the http-proxy? I see you're on the publisher's list. |
|
Well... We are trying to close two other issues before next minor release. Feel free to clone the |
|
@cronopio sounds great! Thanks. :) |
|
@bkw Hi, this fix come in the version |
|
Thank you guys! |
bkw
added a commit
to bkw/distribute
that referenced
this pull request
Jul 25, 2012
rauchg
added a commit
to LearnBoost/distribute
that referenced
this pull request
Oct 11, 2012
bump http-proxy dependency for http-party/node-http-proxy#266
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When routed via multiple proxies, x_forwarded_proto set as httphttps or
wswss instead of http,https or ws,wss, since + operator seems to have a
higher precedence than the terniary operator and the expression was
getting evaluated to true always