Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mention Harmon used for response modifications in the readme #384

Merged
merged 2 commits into from
Mar 16, 2013

Conversation

No9
Copy link
Contributor

@No9 No9 commented Mar 16, 2013

As requested by @indexzero #382
Not sure exactly where I should put the text but middleware seemed to be the best section to me.

indexzero added a commit that referenced this pull request Mar 16, 2013
Mention Harmon used for response modifications in the readme
@indexzero indexzero merged commit 3ebc795 into http-party:master Mar 16, 2013
@gurjeet
Copy link

gurjeet commented Mar 4, 2014

@indexzero @No9 This merge/code has been lost to later merges. This is a very useful information, and should be in the README!

Please re-pull this.

@jcrugzz
Copy link
Contributor

jcrugzz commented Mar 4, 2014

@gurjeet while this is an awesome plugin it is no longer compatible with the newest implementation as node-http-proxy has been simplified.

@gurjeet
Copy link

gurjeet commented Mar 4, 2014

@jcrugzz Thanks for letting me know! I was planning on using it, but you saved me some head-banging :)

Are there any alternatives packages available?

@No9
Copy link
Contributor Author

No9 commented Mar 10, 2014

@gurjeet harmon is OPEN open source.
If you make an accepted pull request to upgrade to 1.0.0 http-proxy I will add you as an administrator

@No9
Copy link
Contributor Author

No9 commented Apr 16, 2014

@jcrugzz Thanks for your kind words!

So i have updated the harmon docs and tests to reflect the 1.x release version of http-proxy and we have upgraded trumpet. Can you let me know if you would accept a pull request on the README again or are you putting it somewhere else now?
cc @gurjeet @indexzero

@jcrugzz
Copy link
Contributor

jcrugzz commented Apr 17, 2014

@No9 I would totally accept a PR to put that in the docs :).

@No9 No9 mentioned this pull request Oct 15, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants