Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Only emit response if a valid server is present #549

Merged
merged 1 commit into from
Jan 14, 2014
Merged

Only emit response if a valid server is present #549

merged 1 commit into from
Jan 14, 2014

Conversation

mmoulton
Copy link
Contributor

When a callback is passed into .web() such as:

proxy.web(req, res, function (err) {
  // handle error
});

the server var is set to false and therefor can't emit the proxyRes.

yawnt added a commit that referenced this pull request Jan 14, 2014
@yawnt
Merge pull request #549 from mmoulton/caronte
0ba4fa8 
Only emit response if a valid server is present
@yawnt yawnt merged commit 0ba4fa8 into http-party:caronte Jan 14, 2014
@yawnt
Copy link
Contributor

yawnt commented Jan 14, 2014

+1.. thanks

@yawnt yawnt mentioned this pull request Jan 14, 2014
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mmoulton @yawnt