Don't override connection header if Upgrading #640
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jayharris mind adding a test case for this? But thanks for the contribution! |
|
@jcrugzz Done. |
|
Not quite sure why Travis fails. It is green, locally. |
|
@jayharris awesome thanks! Tests are failing due to SSL things on |
jcrugzz
added a commit
that referenced
this pull request
May 10, 2014
Don't override connection header if Upgrading
|
Sweet! Any chance of this PR warranting a push to NPM? I have a few issues on @linemanjs that I'm trying to get closed up. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As a patch to #488, do not override the connection header to 'close' if we are upgrading. Always overriding to 'close' prevents upgrades on agent-less sockets, as the proxy destination will never receive the upgrade request. With this change, we leave 'upgrade' requests alone, and let them do their thing.
This also addresses #638.