Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add websockets #686

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Add websockets #686

wants to merge 2 commits into from

Conversation

Yarn
Copy link

@Yarn Yarn commented Aug 21, 2020

Adds websocket support.

Description

See ticket for now.

Motivation and Context

Some people need websockets.

#67

How Has This Been Tested?

tbd (existing cargo tests pass)
https://github.com/Yarn/tide_ws_test

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@Yarn Yarn mentioned this pull request Aug 21, 2020
@jbr
Copy link
Member

jbr commented Sep 3, 2020

What's the plan forward for these PRs? Do you want to hand them off?

@Yarn
Copy link
Author

Yarn commented Sep 3, 2020

I'd like a close code review, especially for the async-h1 changes. Probably benchmarking too, I have a new computer that will probably have less sporadic performance issues so I can probably do that now if there are benchmarks written.

If people want to contribute docs/tests/examples I definitely wouldn't mind but I am planning to work on it more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants