Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keyword arguments, when were they first used? #16

Closed
olleolleolle opened this issue May 17, 2017 · 3 comments
Closed

Keyword arguments, when were they first used? #16

olleolleolle opened this issue May 17, 2017 · 3 comments
Assignees
Labels

Comments

@olleolleolle
Copy link
Contributor

olleolleolle commented May 17, 2017

Hello,

I'm wondering about Ruby keyword arguments in form_data. Keyword arguments are a Ruby 2.0 feature. (Ruby 2.1 gave us "required keyword arguments". Source)

Which version introduced their usage?

I'm wondering because I am trying to make reel build on JRuby 1.7.x

@ixti
Copy link
Member

ixti commented May 17, 2017

Sorry about that. Will fix asap. The idea is following:

  1. release 1.0.3 with kwargs being replaced with optional opts hash and add min required ruby version to gemspec as 1.9
  2. v2+ will have kwargs and min ruby requirement 2.1

Will that work for you?

@ixti ixti self-assigned this May 17, 2017
@ixti ixti added the bug label May 17, 2017
@olleolleolle
Copy link
Contributor Author

olleolleolle commented May 18, 2017 via email

ixti added a commit that referenced this issue May 18, 2017
This commit contains no real changes except it reverts keyword args
usage to use optional options hash instead for ruby < 2 compatibility.

See: #16
     celluloid/reel#243
ixti added a commit that referenced this issue May 18, 2017
This commit contains no real changes except it reverts keyword args
usage to use optional options hash instead for ruby < 2 compatibility.

Resoves #16

------------------------------------------------------------------------

- #16
- celluloid/reel#243
@olleolleolle
Copy link
Contributor Author

...and now it builds! Thanks!

jsonn pushed a commit to jsonn/pkgsrc that referenced this issue Jun 5, 2017
## 1.0.3 (2017-05-18)

* [#16](httprb/form_data#16)
  Fix ruby < 2.0.0 support.
  [@ixti][]


## 1.0.2 (2017-05-08)

* [#5](httprb/form_data#5)
  Allow setting Content-Type non-file parts
  [@abotalov]

* [#6](httprb/form_data#6)
  Creation of file parts without filename
  [@abotalov]

* [#11](httprb/form_data#11)
  Deprecate `HTTP::FormData::File#mime_type`. Use `#content_type` instead.
  [@ixti]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants