New feature: RaiseError #792
Merged
+98
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ixti
reviewed
Nov 9, 2024
lib/http/features/raise_error.rb
Outdated
Comment on lines
13
to
17
| if response.code >= 400 && [email protected]?(response.code) | ||
| raise HTTP::StatusError, "Unexpected status code #{response.code}" | ||
| end | ||
|
|
||
| response |
There was a problem hiding this comment.
WDYT about:
Suggested change
| if response.code >= 400 && !@ignore.include?(response.code) | |
| raise HTTP::StatusError, "Unexpected status code #{response.code}" | |
| end | |
| response | |
| return response if response.code < 400 | |
| return response if @ignore.include?(response.code) | |
| raise HTTP::StatusError, response |
Then changing HTTP::StatusError to:
class StatusError < ResponseError
attr_reader :response
def initialize(response)
@response = response
super("Unexpected status code #{response.code}")
end
end
ixti
reviewed
Nov 9, 2024
| let(:ignored) { [500] } | ||
|
|
||
| it "raises" do | ||
| expect { result }.to raise_error(HTTP::StatusError, "Unexpected status code 500") |
There was a problem hiding this comment.
shouldn't it not raise an error if 500 is ignored?
ixti
reviewed
Nov 9, 2024
|
|
||
| context "when error status is ignored" do | ||
| let(:status) { 500 } | ||
| let(:ignored) { [500] } |
There was a problem hiding this comment.
Suggested change
| let(:ignored) { [500] } | |
| let(:ignore) { [500] } |
|
Thanks for the review. I have addressed your comments. |
ixti
approved these changes
Nov 11, 2024
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The library raises errors if the server does various unexpected things, e.g.
TooManyRedirectsError, but it does not raise if the HTTP status code indicates a client error (4xx) or server (5xx) error.Sometimes you are interested in non-successful responses, and sometimes you just want to treat them as any other error triggered by the server.
This PR adds a new feature that will raise an exception on status codes representing an error. If you want to skip this for specific codes, you can specify them in the
ignoreoption.