Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set the version of the HTTP Server based in the project version #421

Merged
merged 1 commit into from
Jul 9, 2019
Merged

Set the version of the HTTP Server based in the project version #421

merged 1 commit into from
Jul 9, 2019

Conversation

Vkt0r
Copy link
Member

@Vkt0r Vkt0r commented Jul 2, 2019 •
edited
Loading

  • Set the version of the HTTP Server based in the project version in the Info.plist for iOS, macOS, and tvOS. (The use of Bundle is not yet in Linux)

@swifter-bot
Copy link

swifter-bot commented Jul 2, 2019 •
edited
Loading

2 Warnings
⚠️ It seems like you’ve added new tests to the library. If that’s the case, please update the XCTestManifests.swift file running in your terminal the command swift test --generate-linuxmain.
⚠️ If you ran the command swift test --generate-linuxmain in your terminal, please remove the line testCase(IOSafetyTests.__allTests__IOSafetyTests), from public func __allTests() -> [XCTestCaseEntry] in the bottom of the file. For more reference see #366.
1 Message
📖 Hey, @Vkt0r 👋.

Generated by 🚫 Danger

@Vkt0r
Copy link
Member Author

Vkt0r commented Jul 2, 2019

I reported the Linux issue with CircleCI support as the issue is trying to run swift test once the Docker image is loaded.

@Vkt0r
Set the version of the HTTP Server based in the project version
db9257d 
* Set the version of the HTTP Server based in the project version in the Info.plist for macOS, iOS and tvOS platforms
* Update the CHANGELOG
@Vkt0r Vkt0r merged commit 9994415 into httpswift:stable Jul 9, 2019
@Vkt0r Vkt0r deleted the project-version branch July 9, 2019 14:17
tomieq pushed a commit to tomieq/swifterfork that referenced this pull request Apr 1, 2021
@Vkt0r
Merge pull request httpswift#421 from Vkt0r/project-version
1df9676 
Set the version of the HTTP Server based in the project version
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pvzig pvzig pvzig approved these changes

@adamkaplan adamkaplan Awaiting requested review from adamkaplan

@damian-kolakowski damian-kolakowski Awaiting requested review from damian-kolakowski

@ignatovSA ignatovSA Awaiting requested review from ignatovSA

@julien-c julien-c Awaiting requested review from julien-c

@marcc-orange marcc-orange Awaiting requested review from marcc-orange

@mbarnach mbarnach Awaiting requested review from mbarnach

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Vkt0r @swifter-bot @pvzig